search

zio / zio-metrics-connectors

Monitoring, Metrics and Diagnostics for ZIO
https://zio.dev/zio-metrics-connectors
Apache License 2.0
30 stars 24 forks source link

Use time_unit tag from Metric.timer to set baseUnit for Micrometer's DistributionSummary #56

Closed vladimirkl closed 1 year ago

vladimirkl commented 1 year ago

This PR adds handling for Metric.timer in Micrometer connector via setting baseUnit to conform Micrometer's conventions. time_unit tag is hardcoded currently in Metric.timer implementation. @Grryum FYI

Grryum commented 1 year ago

nice PR, thank you, @vladimirkl :)

vladimirkl commented 1 year ago

@petoalbert Could you take a look, please?

petoalbert commented 1 year ago

Thank you @vladimirkl!