search

zio / zio-metrics-legacy

⛔️ DEPRECATED
https://zio.github.io/zio-metrics
Apache License 2.0
56 stars 39 forks source link

Package structure for statsd should follow current accessM paradigms #62

Open blast-hardcheese opened 3 years ago

blast-hardcheese commented 3 years ago

My expectation when looking at zio.metrics.statsd was to find only the accessM proxy methods to whatever underlying layer is eventually supplied, the Has[???] type, and the layer constructors (clients, objects, etc).

I expect that moving everything around to what I think would be common idioms, set out by things like zio-logging and zio's built-in layers, should be coordinated with a ABI-breaking release, but I'm raising this issue just to start the discussion.

toxicafunk commented 3 years ago

Hi @blast-hardcheese,

Thanks for your input and sorry for the late reply. There is a lot of work related to statsd reporting on zio-zmx, in particular this PR: https://github.com/zio/zio-zmx/pull/155

I suggest you can have a look and possibly add to the discussion there, then we can decide whether to bring the changes to zio-metrics or if zio-zmx cover your needs better.