search

zio / zio-mock

https://zio.dev/zio-mock
Apache License 2.0
27 stars 33 forks source link

Fix assertion rendering on mock failures #45

Closed SirStoke closed 1 year ago

SirStoke commented 1 year ago

Fixes #35 by using the utilities implemented in zio/zio#7641

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

SirStoke commented 1 year ago

I see the #render() method on assertions was rolled back in zio/zio#7713, I'm going to convert this to draft until a new one gets implemented

regiskuckaertz commented 1 year ago

@SirStoke hello 👋 do you have capacity to rebase your PR? very interested in that lovely fix 😄

regiskuckaertz commented 1 year ago

Hmm, actually the render method has been reverted due to some other issues, we need to give it a bit more thought

mikail-khan commented 1 year ago

Any news on when this PR can be updated and merged?

leszekgruchala commented 1 year ago

@mikail-khan It's not ideal, but you can extend your spec with MockSpecDefault to render the mock failures information.

jgranstrom commented 1 year ago

Is this back on the table now with https://github.com/zio/zio/pull/8498?

SirStoke commented 1 year ago

Is this back on the table now with zio/zio#8498?

Hi! It seems like it would be, but I'm not involved with zio at work anymore, so I don't really have the motivation or time to fix the PR. Sorry about that.

FWIW, unless something major has changed in zio-mock, it should be really easy to port this fix using the new method