search

zio / zio-protoquill

Quill for Scala 3
Apache License 2.0
204 stars 48 forks source link

add scalafmt to protoquill #356

Closed juliano closed 11 months ago

juliano commented 11 months ago

We don't have any formatter configured, so I am adding the scalafmt with the same configuration used in quill, updating only the dialect

guizmaii commented 11 months ago

The test are failing 🤔

juliano commented 11 months ago

Should be only formatting, I don't get why those tests are failling 🤔

guizmaii commented 11 months ago

Maybe because of the new "significant indentation" of Scala3? 🤔

guizmaii commented 11 months ago

@juliano I suggest that we disable Scala3 significant indentation (made here https://github.com/zio/zio-protoquill/pull/357) and then we apply scalafmt. WDYT?

Note that you'll need these scalafmt conf: https://x.com/ghostdogpr/status/1706589471469425074?s=20

juliano commented 11 months ago

@guizmaii I wasn't aware of this one, I will merge your pr and update this one!

guizmaii commented 11 months ago

and update this one!

It'll be easier to remake it! 😄

juliano commented 11 months ago

New attempt here: https://github.com/zio/zio-protoquill/pull/358