Open timzaak opened 9 months ago
Thanks for the PR, that is indeed solving the example that I opened in the issue, however I would like to challenge the fix (take it with a grain of salt though, I was not able to provide a solution myself), but does it make sense for to External
(as in List[External]
) to have the same UID ? those are generated by the inline macro lift
so might not be a lot that we can here (becasue the macro would have to generate another UID each time it's expanded, which kind of break the purpose of inline, as far as I could tell), this is more a food for thought than an actual review.
Regarding the scala implementation on the fix, see the comment on the code directly
Thanks a lot
Fixes #318
This just resolve some easy use cases.
but would also have problems when using liftQuery for this test case.