Remove config from exception when Hikari data source can't be created - Githubissues

zio / zio-protoquill

Quill for Scala 3

Apache License 2.0

205 stars 48 forks source link

Remove config from exception when Hikari data source can't be created #429

Closed GeorgeII closed 6 months ago

GeorgeII commented 6 months ago

Problem

The config with password is printed in logs when an application can't establish a JDBC connection.

The exact same thing was fixed here: https://github.com/zio/zio-quill/pull/2503 This PR is targeted for Scala 3.

Solution

Remove printing config to stacktrace so that it's fixed in Scala 3 as well.

Notes

Am I right that it will fix the issue for Scala 3?

Checklist

[x] Unit test all changes
[x] Update README.md if applicable
[x] Add [WIP] to the pull request title if it's work in progress
[x] Squash commits that aren't meaningful changes

@getquill/maintainers

CLAassistant commented 6 months ago

All committers have signed the CLA.