Closed GrigoriiBerezin closed 5 months ago
Was there any reason to have an internal module inside a Kafka module?
Is it ok or should I make some improvements?
This is already a huge improvement!
Still, there are always more things to fix (since you're asking 😄 ):
enableZIO(enableStreaming = true)
setting in build.sbt
is not present in normal sbt projects. What does it do, can we replace it with something more standard?tap
which destroys the chunking structure. In almost every application this will hurt performance a lot. Perhaps replace it with mapChunks
, or just put a comment on it? 🤷 Regardless, I think this is already nice to merge! (@guizmaii who has merge rights in this project, you?)
Regardless, I think this is already nice to merge! (@guizmaii who has merge rights in this project, you?)
I don't but I can ask to get the rights
This is already a huge improvement!
Still, there are always more things to fix (since you're asking 😄 ):
- The
enableZIO(enableStreaming = true)
setting inbuild.sbt
is not present in normal sbt projects. What does it do, can we replace it with something more standard?- The consumer uses
tap
which destroys the chunking structure. In almost every application this will hurt performance a lot. Perhaps replace it withmapChunks
, or just put a comment on it? 🤷Regardless, I think this is already nice to merge! (@guizmaii who has merge rights in this project, you?)
Thanks, will do it in next MRs, I have some more quickstarts for repo :)
@khajavi has the rights I guess
All committers have signed the CLA.