zio / zio-quickstarts

A minimal quickstart ZIO application for writing a RESTful Web Service
https://zio.dev/guides/#quickstart-guides
62 stars 39 forks source link

Update zio-kafka version for quick start #46

Closed GrigoriiBerezin closed 5 months ago

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

GrigoriiBerezin commented 5 months ago

Was there any reason to have an internal module inside a Kafka module?

GrigoriiBerezin commented 5 months ago

Is it ok or should I make some improvements?

erikvanoosten commented 5 months ago

This is already a huge improvement!

Still, there are always more things to fix (since you're asking 😄 ):

Regardless, I think this is already nice to merge! (@guizmaii who has merge rights in this project, you?)

guizmaii commented 5 months ago

Regardless, I think this is already nice to merge! (@guizmaii who has merge rights in this project, you?)

I don't but I can ask to get the rights

GrigoriiBerezin commented 5 months ago

This is already a huge improvement!

Still, there are always more things to fix (since you're asking 😄 ):

  • The enableZIO(enableStreaming = true) setting in build.sbt is not present in normal sbt projects. What does it do, can we replace it with something more standard?
  • The consumer uses tap which destroys the chunking structure. In almost every application this will hurt performance a lot. Perhaps replace it with mapChunks, or just put a comment on it? 🤷

Regardless, I think this is already nice to merge! (@guizmaii who has merge rights in this project, you?)

Thanks, will do it in next MRs, I have some more quickstarts for repo :)

GrigoriiBerezin commented 5 months ago

@khajavi has the rights I guess