search

zio / zio-quickstarts

A minimal quickstart ZIO application for writing a RESTful Web Service
https://zio.dev/guides/#quickstart-guides
60 stars 39 forks source link

Quickstart for zio sql #52

Closed GrigoriiBerezin closed 1 month ago

GrigoriiBerezin commented 2 months ago

Just noticed that tests don't work for all projects except encode-decode-json. Can we somehow fix it by zio-sbt-ci?

GrigoriiBerezin commented 2 months ago

@khajavi finally deal with zio sbt plugin and include all tests from needed modules

khajavi commented 2 months ago

@GrigoriiBerezin Can you please update the PR and remove any links to external images? It's better to use a random UUID for each image.

GrigoriiBerezin commented 2 months ago

Ok, will remove links. And what did you mean by "use a random UUID" for each image? Just insert rows in spec instead of migration script?

khajavi commented 2 months ago

Ok, will remove links. And what did you mean by "use a random UUID" for each image?

I meant it is not necessary to have real image data, you can use UUID for each image instead of external URLs.

Just insert rows in spec instead of migration script?

No problem with the migration script. So let's keep it.

GrigoriiBerezin commented 1 month ago

Sorry for long wait, removed real image urls

khajavi commented 1 month ago

@GrigoriiBerezin Good to merge after fixing the merge conflict.

GrigoriiBerezin commented 1 month ago

Will fix links in readme in next quickstarts