search

zio / zio-quill

Compile-time Language Integrated Queries for Scala
https://zio.dev/zio-quill
Apache License 2.0
2.15k stars 348 forks source link

Execute cassandra query in zio.blocking incurs cause a lot of extra latency. #2481

Open mingyang91 opened 2 years ago

mingyang91 commented 2 years ago

Version: v3.16.5 Module: quill-cassandra-zio Database: cassandra

Recently I noticed that my software handles more than 100qps, will get a lot of extra latency. So, I wonder why we must execute cassandra query in blocking? isolating operator in driver that may cause blocking potentially? If yes, have any other method to do this?

https://github.com/zio/zio-quill/blob/c6d190320e/quill-cassandra-zio/src/main/scala/io/getquill/CassandraZioContext.scala#L122-L123

jilen commented 2 years ago

At least simpleBlocking like https://github.com/zio/zio-quill/blob/c6d190320e/quill-cassandra-zio/src/main/scala/io/getquill/CassandraZioContext.scala#L83 is unnecessary.

They are non-blocking call indeed, but the execution is put into a cached blocking executor.

Since this context relays on the async cassandra driver api. No blocking is needed here.