zio / zio-redis

A ZIO-based redis client
https://zio.github.io/zio-redis
Apache License 2.0
123 stars 63 forks source link

Collect the list of missing commands #68

Closed mijicd closed 3 years ago

mijicd commented 4 years ago

Redis API has been expanded since the library was designed. The purpose of this issue is to come with the list of missing commands, and decide which ones we are going to support.

regis-leray commented 4 years ago

CONNECTION

CLUSTER

KEYS

GEO

HASHES

LIST

HYPERLOGLOG

SETS

SORTED-SETS

STRINGS

TRANSACTIONS

@mijicd working on the underlying "machinery" needed to support it.

STREAMS

Taken by @anovakovic01 .

SCRIPTING

Taken by @regis-leray .

SERVER

PUB/SUB

regis-leray commented 4 years ago

@mijicd i used https://redis.io/commands to list all commands and only checked what is implemented

amazing job what is currently supported :) I can help you to finish the crossing line :)

mijicd commented 4 years ago

@regis-leray amazing job, thank you! Lots of these were added in the meantime with redis 6, but it would be great if we can support them.

I planned to ship one small usability improvement and cut the 0.0.1 release but my work schedule postponed that. However, I think I'll have that by tomorrow and then we can crunch the rest of the stuff.

Goes without saying, I'd love to have you on board :). In fact, I think this ticket is pretty independent so you (and other volunteers) can start picking most of the commands. I can see how streaming, transactions and cluster are special (they should have separate tickets), but other commands are fairly easy to implement. WDYT?

regis-leray commented 4 years ago

@mijicd of course I will try my best to contribute.

so the plan is to support all missing commands?

And i'm guessing we will add few missing commands for existing group.

is there any particular priority/order? or doesn't matter?

mijicd commented 4 years ago

I think @anovakovic01 is already working on streaming part, the rest of those are open for tackling. I'd prioritize adding the missing commands for existing groups though, just to make some "order" in releases :).

mijicd commented 4 years ago

I have closed 3 related tickets in favor of this one. From now on, please raise your hand for the command (or group of commands) you are interested in. @anovakovic01 already called "dibs" on streaming :).

regis-leray commented 4 years ago

i can try to implement SCRIPTING

mijicd commented 3 years ago

I have split this in multiple subtickets to make it a bit more hackathon friendly :).