search

zio / zio-redis

A ZIO-based redis client
https://zio.github.io/zio-redis
Apache License 2.0
123 stars 63 forks source link

Rename zio-redis-it's BaseSpec to avoid confusion with test's BaseSpec #980

Closed maizy closed 4 months ago

maizy commented 4 months ago

Would it be correct to rename zio.redis.BaseSpec inside modules/redis-it/src/test/scala/zio/redis/BaseSpec.scala?

If so, this PR does it.

The problem is that IntelliJ IDEA imports sbt projects incorrectly and adds an implicit test->test dependency to all dependent modules. This leads to confusing zio.redis.BaseSpec in modules/redis/src/test/scala/zio/redis/BaseSpec.scala and modules/redis-it/src/test/scala/zio/redis/BaseSpec.scala. Also, test's BaseSpec wins over it's BaseSpec.

This problem only affects IJ IDEA, for example VSCode + Metals works as expected.

An alternative solution might be to rename zio.redis package for itegration tests to something like zio.redis_it.

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.