zio / zio-redis

A ZIO-based redis client
https://zio.github.io/zio-redis
Apache License 2.0
123 stars 63 forks source link

fix infinity loop in RedisUri, add tests for ClusterPartitionOutput #984

Closed maizy closed 2 months ago

maizy commented 3 months ago

fixes #970

Bug in RedisUri was introduced when adding TLS support (#930). RedisUri.apply(String) constructor called itself after building connection URI string, causing cluster spec to hang.

Unfortunately I haven't managed to run cluster spec locally yet, but now it's another problem, possibly with NATted network environment inside the test cluster.

maizy commented 3 months ago

Looks like the old docker-compose doesn't exist in ubuntu-latest anymore.

I'll try to update testcontainers, as far as I know the new version knows how to use docker compose plugin.

maizy commented 3 months ago

docker-compose was removed: https://github.com/actions/runner-images/issues/9692

maizy commented 2 months ago

I've made a separate PR to update testcontainers #985

mijicd commented 2 months ago

@maizy please rebase