search

ziofat / material_design_icons_flutter

The Material Design Icons (https://materialdesignicons.com/) Icon pack available as set of Flutter Icons.
MIT License
167 stars 32 forks source link

tree shake not working correctly #58

Open fhuonder opened 1 year ago

fhuonder commented 1 year ago

Hi,

I am using Flutter 3.10.4 and version 7.0.7296 of this library. I noticed that somehow the tree shaking does not work correctly.

Maybe it has something to do with the changes in Flutter 3.10 (tree shake does now work for web as well)?

In my project I only use MdiIcons.XXX. Nothing dynamic. I use around 125 icons. In an older version the tree shaken materialdesignicons-webfont.ttf was 18KB. Now its size is 1MB. The Flutter build says: Font asset "materialdesignicons-webfont.ttf" was tree-shaken, reducing it from 1279992 to 1034252 bytes (19.2% reduction). Something is shaken off but not all of it. I looked into the ttf file with an online font viewer and there I see a lot of icons that are not used in my project.

Any idea where the problem comes from? Is there a bug?

Regards, Florian

ziofat commented 1 year ago

As far as I know, flutter 3.10 does have some changes with this. I will looking into this but breaking changes maybe introduced.

provokateurin commented 1 year ago

I can confirm the behaviour. I also only see 19.2% reduction although I don't use a lot less icons than that.

fhuonder commented 1 year ago

Hi @ziofat

Any news here?

provokateurin commented 1 year ago

https://pub.dev/packages/flutter_material_design_icons is an easy drop-in replacement and the tree shaking works with it.