search

ziolko / aria-devtools

Easily spot missing ARIA labels, misused ARIA roles, and incomplete keyboard support in your web applications.
https://chrome.google.com/webstore/detail/aria-devtools/dneemiigcbbgbdjlcdjjnianlikimpck?hl=en
MIT License
241 stars 8 forks source link

Add support for <details> and <summary> tag #47

Closed mass8326 closed 8 months ago

mass8326 commented 9 months ago

Closes: https://github.com/ziolko/aria-devtools/issues/36

Before: image

After: image

ziolko commented 9 months ago

Hi @mass8326 thank you for this great contribution! I will test it briefly in the next two or three days and then release :)

mass8326 commented 9 months ago

I'm very happy to help out! This tool has given me the ability to really improve our website's accessibility and has inspired me to pay much more attention to semantic html elements.

If this saves you any time, here's the two pages I used for reference: Astro's homepage and 11ty's homepage

Let me know if you run into any cases or have any suggestions where I can improve the renderer!

ziolko commented 8 months ago

@mass8326 sorry that it took longer than expected. I've merged your changes and released a new version to Chrome web store. It should be available in one or two days.

Thank you for help!

ziolko commented 8 months ago

@mass8326 I forgot to ask - do you want to be added to the list of contributors in README?

mass8326 commented 8 months ago

Awesome, thanks for merging it in! I'm excited to be able to better see <details> in aria-devtools from now on.

If you added me to the list of contributors, that'd be pretty neat and appreciated!

ziolko commented 8 months ago

Perfect, I've updated the project README file to add you to the list of contributors.

Cheers, Mateusz