ziondutro
commented
7 years ago Thank you so much for the feedback! I will work on adding comments to my code because that is definitely something I haven't gotten in the habit of. I will look into the dropdown menu and see if I can implement it into the site.
On Nov 9, 2017 6:34 PM, "ad3429" notifications@github.com wrote:
Summary Grade: Satisfactory
Good job! Your files are organized, your code is well structured, and you did a good job at following the client specification and making your site super user friendly. Moreover, your code is generally simple, clean and easy to follow overall so definitely make sure to keep that up!
I have made a few comments about your code. You did a good job at making your page responsive. When I change the size of the browser, all of the elements respond accordingly. This "responsiveness" is a really important aspect of modern web design, and you should certainly make use of it in future sites that you build.
One area of improvement is to make sure to comment your HTML/CSS further even further so its absolutely clear what is happening at each section of your code -- this will become increasingly important as your projects get larger and more complex. Here is a quick reminder on commenting in HTML and CSS:
[image: html_comment] https://user-images.githubusercontent.com/25671399/32640251-c3025de8-c595-11e7-846c-885c82600d86.png
[image: css comment] https://user-images.githubusercontent.com/25671399/32640252-c4208f4c-c595-11e7-91c4-b478f26964f3.png
You did a good job overall of replicating the design of the client specification. Overall, I really like the look and feel of the site! As a further challenge, see if you can incorporate a dropdown menu system in your website! This can be tricky and may require outside research for you to understand, but it is certainly a cool feature to have. I would recommend this resource to get you started:
https://www.w3schools.com/css/css_dropdowns.asp
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ziondutro/f1-3-c2p1-colmar-academy/issues/5, or mute the thread https://github.com/notifications/unsubscribe-auth/AOJYAe76r_qEuoVCgzeHc4Ur3_yFhh2Oks5s07Y3gaJpZM4QY_Hp .
Summary Grade: Satisfactory
Good job! Your files are organized, your code is well structured, and you did a good job at following the client specification and making your site super user friendly. Moreover, your code is generally simple, clean and easy to follow overall so definitely make sure to keep that up!
I have made a few comments about your code. You did a good job at making your page responsive. When I change the size of the browser, all of the elements respond accordingly. This "responsiveness" is a really important aspect of modern web design, and you should certainly make use of it in future sites that you build.
One area of improvement is to make sure to comment your HTML/CSS further even further so its absolutely clear what is happening at each section of your code -- this will become increasingly important as your projects get larger and more complex. Here is a quick reminder on commenting in HTML and CSS:
You did a good job overall of replicating the design of the client specification. Overall, I really like the look and feel of the site! As a further challenge, see if you can incorporate a dropdown menu system in your website! This can be tricky and may require outside research for you to understand, but it is certainly a cool feature to have. I would recommend this resource to get you started:
https://www.w3schools.com/css/css_dropdowns.asp