search

ziontee113 / color-picker.nvim

A powerful Neovim plugin that lets users choose & modify RGB/HSL/HEX colors.
MIT License
283 stars 8 forks source link

Added hex transparency #17

Closed lars-vc closed 2 years ago

lars-vc commented 2 years ago

Added hex transparency to the back of hex codes closes #16 closes #18

ziontee113 commented 2 years ago

Hi @lars-vc , thank you very much for submitting the PR. I tried it out and things are looking good.

One small question I have is that the Transparent HEX value should be at the beginning instead of at the end? According to: https://stackoverflow.com/a/23201304/19205063 https://gist.github.com/lopspower/03fb1cc0ac9f32ef38f4

But there are information like this https://webtools.fineaty.com/ColorInfo/FFFFFF00/en/Information-about-the-FFFFFF00-color.html

I'm unfamiliar with Transparent HEX colors so I can't tell :smile:. What do you think about putting Transparent HEX information at the beginning or at the end? Thank you :)

ziontee113 commented 2 years ago

Also I forgot about when you open the Color Picker when your cursor is on a color, the Color Picker should pick up the color under your cursor. Maybe we can add the feature for Transparent HEX colors in the future?

lars-vc commented 2 years ago

Hi @lars-vc , thank you very much for submitting the PR. I tried it out and things are looking good.

One small question I have is that the Transparent HEX value should be at the beginning instead of at the end? According to: https://stackoverflow.com/a/23201304/19205063 https://gist.github.com/lopspower/03fb1cc0ac9f32ef38f4

But there are information like this https://webtools.fineaty.com/ColorInfo/FFFFFF00/en/Information-about-the-FFFFFF00-color.html

I'm unfamiliar with Transparent HEX colors so I can't tell 😄. What do you think about putting Transparent HEX information at the beginning or at the end? Thank you :)

It is a bit of a toss up, but CSS uses at the back (https://stackoverflow.com/questions/1751263/hex-colors-numeric-representation-for-transparent). So that's why I picked at the back.

lars-vc commented 2 years ago

Also I forgot about when you open the Color Picker when your cursor is on a color, the Color Picker should pick up the color under your cursor. Maybe we can add the feature for Transparent HEX colors in the future?

Ah I forgot about this, Ill fix it tmrw!

ziontee113 commented 2 years ago

Ah I forgot about this, Ill fix it tmrw!

Thank you very much. I'm sorry in advance because that part of the code base is a bit amateurish :smile:

lars-vc commented 2 years ago

Added!

ziontee113 commented 2 years ago

Thank you very much @lars-vc for the amazing PR :smile: