search

zios / unity-themes

Provides the Unity Editor with adjustable, hot-swappable GUI themes across all elements.
MIT License
529 stars 55 forks source link

Problem with animation window #24

Open AbhimanyuAryan opened 7 years ago

AbhimanyuAryan commented 7 years ago

The sprites look black in animation windows & there's no way to detect which sprites has what

lizard_ben

screen shot 2017-05-11 at 1 51 44 pm
bradsmithee commented 7 years ago

Can you attach an example project with the animation window and this issue visible? The reason an area/window is usually not styled correctly is simply because I have no assets/project set up to preview and base the styles from.

AbhimanyuAryan commented 7 years ago

can i share the github project with assets folder and project settings. You can clone the project & open it...in Unity

However. I haven't version controlled @Theme 5.6 ......I ignored that...if you want I can remove it from .gitignore and version control it too

bradsmithee commented 7 years ago

Sure, that sounds fine. No need to version control the themes system.

AbhimanyuAryan commented 7 years ago

it's fixed now. Changed pallet

bradsmithee commented 7 years ago

Hmm. Did not get a chance to check your link and examine the issue before it was taken down. What palette entry was this related to? I assume you needed to make something semi-transparent rather than solid?

AbhimanyuAryan commented 7 years ago

Link to project: https://github.com/AbhimanyuAryan/Glitch-Garden

I have been using these theme and sharing with my friends as well. I want to suggest some improvement if you can do in free time....There's a dark selection issue in editor for which you have suggested a temporary fix(https://forum.unity3d.com/threads/zios-editor-theme-support.411818/page-3). Please include these changes in update as well if possible

screen shot 2017-05-16 at 12 40 47 am screen shot 2017-05-16 at 12 40 53 am

Please make the corner round for "animation window". The bottom scroll bar in animation window has weirdly square corners. Whereas entire Unity3d uses round corners for scroll bars

screen shot 2017-05-16 at 12 41 02 am screen shot 2017-05-16 at 12 41 26 am screen shot 2017-05-16 at 12 41 37 am screen shot 2017-05-16 at 12 42 01 am screen shot 2017-05-16 at 12 45 46 am screen shot 2017-05-16 at 12 44 12 am screen shot 2017-05-16 at 12 43 14 am
bradsmithee commented 7 years ago

I'll get to all of these when I do my next round of fixes, but here's what I assume the issues are off-hand.

A GUIStyle dealing with these background selections likely need to be adjusted to a transparent texture.

Likely a sub-element scrollbar style that isn't assigned in the GUISkin.

Definitely a style I have not touched yet.

If the font is not correct, then it's likely not using one of the proxy fonts in the style. If you are refering to the difficult to read colors, this is more palette related. Unity automatically adds a black drop-shadow on this particular area (not adjustable). To make it visible, it needs to use lighter colored text.

That's very interesting that you have these issues. Are you using the standalone dll release zip or a clone of the repository? If the dll, which version of the dll? What version of Unity? MacOS/Linux/Windows? I'll need to be able to recreate these issues (or at least get the full stack trace of each) to find the problem and fix.

This looks like a padding issue caused by different fonts having different widths. I'm assuming it looks fine on several other standard fonts? Beyond tweaking the x offset values in the Advanced Font header of the Theme system, this one might be tricky to address.

AbhimanyuAryan commented 7 years ago

I'm using Zios.Themes.r573.Windows.560.zip & Unity version is 5.6.0f3