search

ziotom78 / Healpix.jl

Healpix library written in Julia
GNU General Public License v2.0
51 stars 18 forks source link

fix type instability due to array dimension #25

Closed xzackli closed 4 years ago

xzackli commented 4 years ago

Allowing N-dimensional arrays without parametrizing on N can cause type instability, which was slowing down alm2cl (see Julia Performance Tips). Since Healpix arrays are always dimension 1 (as are the a_lm), there is no cost and free performance gains if one specifies the array dimension.

codecov[bot] commented 4 years ago

Codecov Report

Merging #25 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files          18       18           
  Lines         755      755           
=======================================
  Hits          611      611           
  Misses        144      144
Impacted Files Coverage Δ
src/alm.jl 95.55% <ø> (ø)
src/map.jl 38.09% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 85bda81...d795676. Read the comment docs.

ziotom78 commented 4 years ago

Nice job, @xzackli !