Rename `readfullweights` and `applyfullweights!`

ziotom78 / Healpix.jl

Healpix library written in Julia

GNU General Public License v2.0

51 stars 18 forks source link

Rename `readfullweights` and `applyfullweights!` #56

Closed ziotom78 closed 3 years ago

ziotom78 commented 3 years ago

The case of the two new functions readfullweights and applyfullweights! to be included in release 3.0 does not match the camel-case standard used for other functions:

ringWeightPath
readWeightRing
pixelWindowPath
readPixelWindowT
etc.

Although the common practice in Julia is to use all-lowercase identifier, I believe the least disruptive change would be to convert to CamelCase the two functions, i.e., readFullWeights and applyFullWeights!.

@xzackli, what do you think?

xzackli commented 3 years ago

I think changing those functions to camel case would be fine -- the package is currently split into "foo2bar" and camel case methods, and I think that is ok. Makes sense to enforce consistency!

ziotom78 commented 3 years ago

Fixed by #55.