search

ziotom78 / Healpix.jl

Healpix library written in Julia
GNU General Public License v2.0
51 stars 18 forks source link

Update map_pixelfunc.jl #72

Closed xzackli closed 2 years ago

xzackli commented 2 years ago

This is a breaking change, but the keyword argument pess=false here should be the same between the ring and nest order implementations.

codecov[bot] commented 2 years ago

Codecov Report

Merging #72 (45dc424) into master (c1506d9) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   86.66%   86.66%           
=======================================
  Files          18       18           
  Lines         990      990           
=======================================
  Hits          858      858           
  Misses        132      132
Impacted Files Coverage Δ
src/map_pixelfunc.jl 90.54% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c1506d9...45dc424. Read the comment docs.

ziotom78 commented 2 years ago

Thanks @xzackli , before merging this may you please update the CHANGELOG and highlight that this is a breaking change?