ziotom78 / Healpix.jl

Healpix library written in Julia
GNU General Public License v2.0
51 stars 18 forks source link

Use a more robust algorithm for vec2ang #76

Closed ziotom78 closed 2 years ago

ziotom78 commented 2 years ago

As discussed in the litebird_sim repo, we are using a numerically unstable implementation of vec2ang. This PR implements the same formula as ducc0, which is more accurate near the poles. A new test has been added as well.

codecov[bot] commented 2 years ago

Codecov Report

Merging #76 (d5f1061) into master (933dd79) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   84.82%   84.80%   -0.02%     
==========================================
  Files          18       18              
  Lines         929      928       -1     
==========================================
- Hits          788      787       -1     
  Misses        141      141              
Impacted Files Coverage Δ
src/pixelfunc.jl 83.52% <100.00%> (-0.10%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 933dd79...d5f1061. Read the comment docs.