search

ziotom78 / Healpix.jl

Healpix library written in Julia
GNU General Public License v2.0
51 stars 18 forks source link

Add Base.parent to HealpixMap #78

Closed xzackli closed 2 years ago

xzackli commented 2 years ago

This adds the standard method parent for a HealpixMap, which yields the parent array.

codecov[bot] commented 2 years ago

Codecov Report

Merging #78 (6906850) into master (71f2020) will decrease coverage by 0.09%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   84.80%   84.71%   -0.10%     
==========================================
  Files          18       18              
  Lines         928      929       +1     
==========================================
  Hits          787      787              
- Misses        141      142       +1
Impacted Files Coverage Δ
src/map.jl 62.50% <0.00%> (-2.02%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 71f2020...6906850. Read the comment docs.

ziotom78 commented 2 years ago

Sounds good, thanks!

If you add a line to CHANGELOG, we can merge this immediately.

xzackli commented 2 years ago

I thought I had broken something with this commit, so I had temporarily closed it -- sorry for any confusion.

Healpix maps are missing similar.

ziotom78 commented 2 years ago

Hi @xzackli , I have done a number of additions to the library and would like to publish a new release (4.0? there is a small breaking change). Do you think it's worth waiting for this PR to be merged before releasing it?

xzackli commented 2 years ago

Feel free to tag a new version! I think this PR is basically ready, but it's not a big deal.

Sorry for the delay, just got back from some academic travel.