search

ziotom78 / Healpix.jl

Healpix library written in Julia
GNU General Public License v2.0
51 stars 18 forks source link

Implement queryDiscRing and queryStripRing #80

Closed ziotom78 closed 2 years ago

ziotom78 commented 2 years ago

This pull request implements queryDiscRing (issue #27). The task was longer than expected, because the implementation required implementing several other functions in the library:

At the moment I only implemented the algorithm for maps following the RING scheme, as queryDisc is most efficient in this case. The implementation for the NEST scheme will have to wait.

codecov[bot] commented 2 years ago

Codecov Report

Merging #80 (7120b39) into master (71f2020) will increase coverage by 1.86%. The diff coverage is 95.68%.

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   84.80%   86.66%   +1.86%     
==========================================
  Files          18       19       +1     
  Lines         928     1065     +137     
==========================================
+ Hits          787      923     +136     
- Misses        141      142       +1
Impacted Files Coverage Δ
src/Healpix.jl 100.00% <ø> (ø)
src/query.jl 93.54% <93.54%> (ø)
src/nside.jl 100.00% <100.00%> (ø)
src/pixelfunc.jl 88.73% <100.00%> (+5.20%) :arrow_up:
src/resolution.jl 92.30% <100.00%> (+0.64%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 71f2020...7120b39. Read the comment docs.

ziotom78 commented 2 years ago

All the tests pass but the ones running Julia nightly. Nevertheless, I'm merging this PR.