search

ziotom78 / Healpix.jl

Healpix library written in Julia
GNU General Public License v2.0
51 stars 18 forks source link

New functions: alm algebraic operations and indexing #98

Closed LeeoBianchi closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #98 (426fe60) into master (73e17d4) will increase coverage by 0.92%. The diff coverage is 97.81%.

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   88.79%   89.71%   +0.92%     
==========================================
  Files          20       20              
  Lines        1330     1449     +119     
==========================================
+ Hits         1181     1300     +119     
  Misses        149      149
Impacted Files Coverage Δ
src/Healpix.jl 100.00% <ø> (ø)
src/cl.jl 93.10% <ø> (ø)
src/sphtfunc.jl 97.52% <ø> (ø)
src/alm.jl 97.34% <97.41%> (+2.18%) :arrow_up:
src/map_pixelfunc.jl 91.02% <100.00%> (+0.48%) :arrow_up:
src/pixelfunc.jl 90.24% <100.00%> (+0.50%) :arrow_up:
src/resolution.jl 92.85% <100.00%> (+0.54%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

LeeoBianchi commented 1 year ago

@ziotom78 I've pushed a couple of simple functions I had to code up for my work which I think could be useful for a Healpix user in general.

With this I think the PR can be merged, if you're happy with it.

Btw, having all these new functions included in a new Healpix.jl version would make things much easier for the release of my new package :)

ziotom78 commented 1 year ago

@ziotom78 I've pushed a couple of simple functions I had to code up for my work which I think could be useful for a Healpix user in general.

With this I think the PR can be merged, if you're happy with it.

Btw, having all these new functions included in a new Healpix.jl version would make things much easier for the release of my new package :)

Great! I'm fine with these changes, so we can merge the PR. But can you please add a entry in the CHANGELOG listing the functions that this PR adds?

LeeoBianchi commented 1 year ago

Great! I'm fine with these changes, so we can merge the PR. But can you please add a entry in the CHANGELOG listing the functions that this PR adds?

I added one last function to get the pixels corresponding to a specific ring in a map, which I had in my scripts and thought could be useful when operating with HealpixMaps. I also updated the CHANGELOG.md.

Everything should be in place now!