search

zip-rs / zip-old

Zip implementation in Rust
MIT License
731 stars 204 forks source link

Fix targets without 64-bit atomics. #285

Closed n3vu0r closed 2 years ago

n3vu0r commented 2 years ago

Fixes #284. As soon as MSRV >= 1.60.0 we might use target_has_atomic = "64" instead of target_arch.

zamazan4ik commented 2 years ago

Thanks for the PR! However, I think we cannot merge it yet since bumping MSRV to 1.60 violates our MSRV policy. I propose just wait for some time and then merge it.

If you need this fix urgently, I suggest just use your own fork during some time and then switch to the mainstream when it will be merged.

zamazan4ik commented 2 years ago

Another option of course will be implementing missed functionality with some 3rd party creates which allows to enbale MIPS support without newer compiler.

paolobarbolini commented 2 years ago

Thanks for the PR! However, I think we cannot merge it yet since bumping MSRV to 1.60 violates our MSRV policy. I propose just wait for some time and then merge it.

This PR by itself doesn't bump MSRV. What we meant is that once the MSRV will be high enough we'll be able to replace any(target_arch = "mips", target_arch = "powerpc") with target_has_atomic = "64"

zamazan4ik commented 2 years ago

Ah, I see - my bad. Just did not understand you correctly. LGTM.

@Plecra could you check it too?

messense commented 2 years ago

Could you please release a new version? Thanks!

zamazan4ik commented 2 years ago

@Plecra that is a question for you )