search

zip-rs / zip-old

Zip implementation in Rust
MIT License
731 stars 204 forks source link

Depend Fix [zstd] #320

Closed wyatt-herkamp closed 2 years ago

wyatt-herkamp commented 2 years ago

when compiling with Actix web the exact version depend 0.11.0 creates a conflict with actix-web

By setting it to just 0.11 it can use any patch version of 0.11 so 0.11.0 or 0.11...

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-cratesio

danylaporte commented 2 years ago

I have run into the conflict version with actix-web. Is it possible to fix the clippy issues and merge the pull request?

wyatt-herkamp commented 2 years ago

I have run into the conflict version with actix-web. Is it possible to fix the clippy issues and merge the pull request?

So the clippy breaks are just related to new clippy rules nothing I changed. However they should be fixed now

Heliozoa commented 2 years ago

zstd = { version = "0.11", optional = true } and zstd = { version = "0.11.0", optional = true } are the exact same from Cargo's perspective because Cargo (mostly) follows SemVer. 0.11.0 already allows use of any 0.11.z patch release.

The problem is that the latest release of zip, 0.6.2, still uses zstd 0.10: https://crates.io/crates/zip/0.6.2/dependencies

wyatt-herkamp commented 2 years ago

zstd = { version = "0.11", optional = true } and zstd = { version = "0.11.0", optional = true } are the exact same from Cargo's perspective because Cargo (mostly) follows SemVer. 0.11.0 already allows use of any 0.11.z patch release.

The problem is that the latest release of zip, 0.6.2, still uses zstd 0.10: crates.io/crates/zip/0.6.2/dependencies

That's what I had thought. I will revert that file change and keep the pr open as a clippy warning fix