zip-rs / zip-old

Zip implementation in Rust
MIT License
731 stars 204 forks source link

Add zstd-pkg-config feature #321

Closed figsoda closed 2 years ago

figsoda commented 2 years ago

This is so consumers of zip can use the pkg-config feature of zstd without manually adding a zstd dependency

Plecra commented 2 years ago

I believe the intended use of cargo is for dependent crates to explicitly opt into zstd themselves - this allows us to potentially update to newer versions of zstd internally even if they remove pkg-config support. If you manually add a zstd dependency, cargo will automatically find the suitable version of zip to continue supporting pkg-config. Do you think I'm getting something wrong here?