search

zip-rs / zip-old

Zip implementation in Rust
MIT License
731 stars 204 forks source link

Implement TryFrom<OffsetDateTime> for DateTime #330

Closed aquacash5 closed 1 year ago

aquacash5 commented 1 year ago

This allows users to use try_into when converting OffsetDateTime into DateTime and deprecates the previous specialized method.

Plecra commented 1 year ago

@zamazan4ik would like to get this in and then publish 0.6.4. If you get the chance to prep the release before me, that'd be fantastic!

aquacash5 commented 1 year ago

@Plecra These should address the changes you requested.

Plecra commented 1 year ago

Need to run the tests on CI - could you sort out those warnings?

aquacash5 commented 1 year ago

That should fix it. I tried running the commands in the workflow on all the computers I have access to. I don't get any warnings or errors.

Plecra commented 1 year ago

Alright, just rebased that on the clippy fixes :) I think we're left with a couple deprecated references which I can fix up just now...