search

zip-rs / zip-old

Zip implementation in Rust
MIT License
731 stars 204 forks source link

Disable `time` features #333

Closed lnicola closed 1 year ago

lnicola commented 1 year ago

I left these enabled in dev-dependencies, so that the tests still work, but to be honest, I don't think those tests are really useful.

The reason to disable this is the proc macro stuff has a significant build time impact, and it's not really something zip users need.

zamazan4ik commented 1 year ago

@Plecra we need your opinion here.

Plecra commented 1 year ago

Hmm, I'm not sure about standard ways to to this, but I can pop a CHANGELOG.md in the root.

Plecra commented 1 year ago

Oops! We've got a bug in the fuzz CI. You'll need to add "std" to the featureset for time, otherwise we can't get the current time.

Plecra commented 1 year ago

(That's https://docs.rs/time/latest/time/struct.OffsetDateTime.html#method.now_utc btw - it mentions the feature dep)

lnicola commented 1 year ago

Done, can you try again? The clippy failures are unrelated. I can file a PR to fix them tomorrow, if you want.

Plecra commented 1 year ago

We need it for release dependencies too :) the now_utc API is used for writing the current time in file metadata.

lnicola commented 1 year ago

Ah, okay. Fixed.

lnicola commented 1 year ago

Thanks! No pressure, but do you think you'll cut out a new release soon?

Plecra commented 1 year ago

Just after addressing the CVE issue, yep!