search

zip-rs / zip-old

Zip implementation in Rust
MIT License
731 stars 204 forks source link

Add deflate-zlib-ng feature flag #365

Closed jirutka closed 5 months ago

Plecra commented 1 year ago

haha yeah, I've never figured out best practices for dependencies' features. Do you think there's a reason we should forward this feature but not every other feature of all our dependencies? (I know that crates will often instead depend directly on flate2 and specify the features themselves)

Ah, but we're already doing this with the other deflate backends. Then this fits. You'll need to add deflate-zlib-ng to the configuration gates, otherwise the crate wont enable support properly. We need tests to pass with cargo test --no-default-features --features deflate-zlib-ng

JakubOnderka commented 1 year ago

I already send this PR: https://github.com/zip-rs/zip/pull/361 that's also adds the configuration gates. And I will also run tests with this feature flag.

Pr0methean commented 5 months ago

This was done in https://github.com/zip-rs/zip2/commit/9ec0ddc5ca09bb2a73374941bef48615267297fb.