search

zip-rs / zip-old

Zip implementation in Rust
MIT License
731 stars 204 forks source link

merge InvalidPassword into ZipError #398

Closed cosmicexplorer closed 5 months ago

cosmicexplorer commented 1 year ago

A lot of the logic in read.rs goes through functions that return a nested Result<Result<...>, InvalidPassword>, which seems unnecessary when we don't even have password support at all in some configurations. This change makes InvalidPassword into a case of ZipError and avoids needing to separately unwrap an InvalidPassword error.

This is a breaking change, because it modifies zip::result::ZipError and removes zip::result::InvalidPassword.

Pr0methean commented 5 months ago

Rendered obsolete by https://github.com/zip-rs/zip2/commit/ece098d39332f97b04e508222d0cc44ae3c1e5c4.