panic when trying to exhaust the stream

zip-rs / zip-old

Zip implementation in Rust

MIT License

731 stars 204 forks source link

panic when trying to exhaust the stream #432

Closed wolfv closed 5 months ago

wolfv commented 8 months ago

The Drop implementation of ZipFile currently panic's when the stream has an issue. Unfortunately we hit this panic sometimes when passing in a reqwest stream into the zipfile (using the read_zipfile_from_stream function).

Would it not be better to ignore errors?

https://github.com/zip-rs/zip/blob/3e88fe66c941d411cff5cf49778ba08c2ed93801/src/read.rs#L1008

Any further operations would anyways error with this particular stream...

Pr0methean commented 5 months ago

Please reopen this against https://github.com/zip-rs/zip2 if it's not fixed in https://github.com/zip-rs/zip2/pull/48. This repo is no longer maintained.