search

zipleen / tvheadend-iphone-client

TvhClient - An iOS (iPhone / iPad) client for TVHeadend
http://tvhclient.com/
Mozilla Public License 2.0
112 stars 25 forks source link

tvOS: add timeshift support #216

Open thenktor opened 6 years ago

thenktor commented 6 years ago

Hi,

pressing the play/pause on the Apple TV remote IMHO should pause playback but it does nothing.

zipleen commented 6 years ago

I'm sorry if you though time shift is available, although I'm really curious to know where you got the impression that time shift should work.

The issue is that time shift option is not available in HTTP streaming via tvheadend - only through HTSP - and vlc only support HTTP streaming.

If any of these two things change, then tvhclient will be able to support time shift.

thenktor commented 6 years ago

Hi,

I could not find anything about it in the known problems section in the app so I did open this bug report / feature request. IMHO it's one of the most important features :(

zipleen commented 6 years ago

I will add specific information that timeshift is not available to that screen, and also to the in app purchase one.

I agree that timeshift is important, however there's very little I can do on the time that I have available. Any help would be very much appreciated though!

tonyschuite commented 6 years ago

apparently it could theoretically work: https://github.com/BtbN/vlc-htsp-plugin

zipleen commented 6 years ago

@tonyschuite check this conversation from 21 march 2017 - https://gitter.im/zipleen/tvheadend-iphone-client?at=58d1199ffe6a638b1aea70d6

There's been multiple conversations throughout the years, basically the only decent way of enabling this is if tvheadend supports it natively

horstepipe commented 6 years ago

hey guess there aren't any good news about this topic?

zipleen commented 6 years ago

nope, nothing new to report on this matter :/

mpietruschka commented 5 years ago

https://trac.videolan.org/vlc/ticket/19553 https://wiki.videolan.org/Documentation:Modules/timeshift https://wiki.videolan.org/VLC_command-line_help/

Doesn't "--http-continuous" activate local timeshift?

Commandline Docs (...) --http-continuous, --no-http-continuous Continuous stream (default disabled) Keep reading a resource that keeps being updated (...) --input-timeshift-path= Timeshift directory Directory used to store the timeshift temporary files. --input-timeshift-granularity= Timeshift granularity This is the maximum size in bytes of the temporary files that will be used to store the timeshifted streams.

mpietruschka commented 5 years ago

VLC HTS Plugin (Legacy) https://github.com/BtbN/vlc-htsp-plugin

zipleen commented 5 years ago

yup, I never said that VLC does not support timeshift, I said that tvheadend must support timeshift through the HTTP protocol =)

In relation to the htsp plugin for vlc, it's very old code and I would need to hack VLCKit in order to built it in. One thing that I learned is that I do not want to ever again have to build VLCKit at all. It's either supported officially bundled with VLCKit, or nothing.

(However there's a way to use HTSP and get vlc to load bytes of stream data instead of giving it a http url :P) (edit: but to be clear, this would be a major endeavour, and I never use timeshift so I have very little motivation to add timeshift - it would be a "cool feature" to show, which probably no one would ever use, because timeshift in tvheadend is limited to going back to what you already watched)

mpietruschka commented 5 years ago

Couln't you just enable the local timeshift in VLC and enable the pause button in the UI?

zipleen commented 5 years ago

there's no local timeshift in vlc :D

at least, from what I know. the only thing that exists is the in memory network cache of vlc, which is basically a few seconds depending on the option you select for how big you want the network cache to be.

if there's any sort of local timeshift in vlc, do let me know how to enable it !

but first, open VLC for iOS and attempt to see if they have it in any way (a few seconds doesn't count, that's just the in memory cache - SD content could have up to 10sec of cache if you have a big enough network cache)

zipleen commented 5 years ago

I've got a proposal. What about opening a bounty for adding htsp protocol with timeshift support in https://www.bountysource.com ?

There's basically multiple ways to achieve this:

The fact is that I don't use timeshift at all in tvheadend, so I have very little incentive to add this feature. If you have a bounty, we can see how many people would actually pay to get this feature!

(not being pessimistic, but I would bet a very very small amount of people would care hehe)

Nastras commented 4 years ago

Hello @zipleen,

i would also be very happy about the timeshift function for the Apple TV and would be willing to pay for it again .-)

So I would like to know what the current status is?

zipleen commented 4 years ago

Hey!

I haven't done anything for this, there's way more things to do if I have time : dark theme support, fix the recordings screen which I'm in the middle of and it would be nice to maybe look at that EPG in the Apple TV version.

Timeshift is way down in the priority list..

Nastras commented 4 years ago

Thanks for the quick answer.

I've only been using your apps for Apple TV and iOS since today and I'm thrilled. Very good work!

That sounds good and bad. I'm glad you're still developing👍 If you ever get bored, Timeshift would be a cool extension to make your app complete 😉

Greetings Nastras