search

zipline-live / zipline

Zipline-Live, a Pythonic Algorithmic Trading Library
http://www.zipline-live.io/
Apache License 2.0
394 stars 65 forks source link

Fix transactions property in alpaca_broker #109

Closed umitanuki closed 6 years ago

umitanuki commented 6 years ago

My last code misunderstood the requirements for transactions property (dict of Transaction, not Order).

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.3%) to 86.172% when pulling 63fdaeab85c545632b1f16ceed62fb04f8d4e520 on alpacahq:alpaca_broker into 954c69deaf2a1900d45b45a8c5591a7904c5d0f0 on zipline-live:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.3%) to 86.172% when pulling 63fdaeab85c545632b1f16ceed62fb04f8d4e520 on alpacahq:alpaca_broker into 954c69deaf2a1900d45b45a8c5591a7904c5d0f0 on zipline-live:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.5%) to 85.954% when pulling 98e860b55c9fc4a8a825fe6c0f558b0fb2866bf8 on alpacahq:alpaca_broker into 954c69deaf2a1900d45b45a8c5591a7904c5d0f0 on zipline-live:master.

tibkiss commented 6 years ago

Is it good to review / merge?

umitanuki commented 6 years ago

Yes it is. I have successfully run live trading with the latest that does bunch of things.