Reminding about missing "notices" for modifications on original work (violation of APACHE-2.0)
Hello,
[Modification terms and conditions in license] The original work should be honored while the modifications on it should be attached with prominent notices as the license APACHE-2.0 dictates. Your project is a forking project from quantopian/zipline which adopts APACHE-2.0 as its project license.
The modification terms and conditions of APACHE-2.0 dictate that:
... You must cause any modified files to carry prominent notices stating that You changed the files ...
Therefore, we think the project is obligated to abide by the modification terms and conditions in APACHE-2.0.
[Violation of modification terms and conditions] We run through your history, and it turns out that you have conducted modifications to the source files of original work while didn't provide prominent notices.
You have 8 commits which conduct modifications to the files of original work, all of which are not declared in README.md, README.rst.
According to the license terms and conditions above, it is regarded as license violation.
Thus, to avoid potential legal risks, I would suggest you carry out prominent notices for the 8 commits.
[Recommended Fix] There are 2 recommended solutions to fulfill the modification related obligation of APACHE-2.0:
Git Mechanism.
Just put a note in the top directory, something like MODIFICATION.md, or any file but the license text and NOTICES, in order to give people who follow you the most latitude to comply with the license without making a mess,
Write "In compliance with the APACHE-2.0 license: I declare that this version of the program contains my modifications, which can be seen through the usual "git" mechanism."
Changelog Text.
Or add changelog for modification to comply with the license.
For your convenience, I created a PR with by picking up modification-related commit messages. It adds a few lines in changelog without touching the codebase. Please be comfortable to check it out.
Full details of the report you could refer to the html file attached.
Hope it helps!
If there is anything wrong in this reminding, I'm sorry for my bothering, and please feel free to close this PR.
Reminding about missing "notices" for modifications on original work (violation of APACHE-2.0)
Hello,
[Modification terms and conditions in license] The original work should be honored while the modifications on it should be attached with prominent notices as the license APACHE-2.0 dictates. Your project is a forking project from quantopian/zipline which adopts APACHE-2.0 as its project license.
The modification terms and conditions of APACHE-2.0 dictate that:
Therefore, we think the project is obligated to abide by the modification terms and conditions in APACHE-2.0.
[Violation of modification terms and conditions] We run through your history, and it turns out that you have conducted modifications to the source files of original work while didn't provide prominent notices. You have 8 commits which conduct modifications to the files of original work, all of which are not declared in README.md, README.rst.
According to the license terms and conditions above, it is regarded as license violation. Thus, to avoid potential legal risks, I would suggest you carry out prominent notices for the 8 commits.
[Recommended Fix] There are 2 recommended solutions to fulfill the modification related obligation of APACHE-2.0:
Git Mechanism.
Changelog Text.
Or add changelog for modification to comply with the license.
For your convenience, I created a PR with by picking up modification-related commit messages. It adds a few lines in changelog without touching the codebase. Please be comfortable to check it out.
Full details of the report you could refer to the html file attached. Hope it helps!
If there is anything wrong in this reminding, I'm sorry for my bothering, and please feel free to close this PR.
Cheers!