search

zipline-live / zipline

Zipline-Live, a Pythonic Algorithmic Trading Library
http://www.zipline-live.io/
Apache License 2.0
394 stars 65 forks source link

Created broker list option #63

Closed janlehky closed 6 years ago

janlehky commented 6 years ago

Small change based on issue #48

tibkiss commented 6 years ago

Thanks for this PR. Unfortunately it has merge conflict due to a recent change in run. Could you please resolve that?

Additionally, we should future proof this PR by building the list of available brokers dynamically. pkg_util.iter_module() is able to provide that information relatively easily.

CC: @bartosh

janlehky commented 6 years ago

Hello,

thanks for your comment, i will resolve it and do what you are asking. Just please give me time till Monday.

tibkiss commented 6 years ago

Sure, thanks for your contribution!

On 2017. Oct 6., at 18:47, Jan Lehky notifications@github.com wrote:

Hello,

thanks for your comment, i will resolve it and do what you are asking. Just please give me time till Monday.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.05%) to 86.123% when pulling fbbc0035c3f98ee9288cc421ef3caabcaeb627b1 on Scapogo:master into 094018e10afdc637d1c7eca3edb0d767a0f6f4ce on zipline-live:master.

tibkiss commented 6 years ago

LGTM, will merge (w/ squash) once AppVeyor has completed

tibkiss commented 6 years ago

Merged into master, thanks for the contribution @Scapogo !