zipline-live / zipline

Zipline-Live, a Pythonic Algorithmic Trading Library
http://www.zipline-live.io/
Apache License 2.0
394 stars 65 forks source link

Update ib_broker.py #93

Closed peterfabakker closed 4 years ago

peterfabakker commented 6 years ago

Warn for not able to subscribe to asset

tibkiss commented 6 years ago

Please change the commit message. Instead of showing what has changed please detail why the change was created. I'd prefer to stick to scipy's conventions: https://docs.scipy.org/doc/numpy/dev/gitwash/development_workflow.html

Thank you.

tibkiss commented 6 years ago

Taken a look on CI: five testcases are failing, plus flake8 problems are present. Please address those as well.

My recommendation would be that we split this up into smaller chunks, where one PR fixes one problem.

tibkiss commented 4 years ago

This change became outdated. Closing.