zipme / redmine_lightbox

Lightbox for image attachments
MIT License
116 stars 118 forks source link

Issue deleting attachments #40

Open mlattke opened 12 years ago

mlattke commented 12 years ago

Hello,

The plugin works great, but I have an issue when I try delete an attachment, don't make anything, if I refresh the page, shows me the attachment in full screen, to delete I need disable the plugin > delete > put again the plugin, I hope you can help me.

Regards.,

dhoelker commented 12 years ago

same issue here

danmunn commented 12 years ago

Can you give some details on redmine version / environment, any browser reported errors etc?

mlattke commented 12 years ago

Hello danmunn,

Redmine version: 1.4.3.stable O.S: Ubuntu 10.04 LTS Browser: Google Chrome 20, IE 8, IE 9

Best regards.,

danmunn commented 12 years ago

I'll have to download redmine 1.4.3 for test, however issue is not present in 2.0.3 (as far as I can see)

mlattke commented 12 years ago

Unfortunately I have another plugins without compatibility on Redmine 2.x even, because of that, I can't upgrade

Thank you I hope you can help us.

dhoelker commented 12 years ago

Hello danmunn,

here some details on my Redmine Version / Environment:

Error in production.log:

Processing ApplicationController#index (for 192.168.78.40 at 2012-07-16 16:24:36) [POST]
  Parameters: {"authenticity_token"=>"Hn6+5J6kc6WFHfxl8Ij7szdf82Doo50nTfKwzRACtS4="}

ActionController::MethodNotAllowed (Only get and delete requests are allowed.):
  :10:in `synchronize'
  passenger (3.0.13) lib/phusion_passenger/rack/request_handler.rb:96:in `process_request'
  passenger (3.0.13) lib/phusion_passenger/abstract_request_handler.rb:516:in `accept_and_process_next_request'
  passenger (3.0.13) lib/phusion_passenger/abstract_request_handler.rb:274:in `main_loop'
  passenger (3.0.13) lib/phusion_passenger/classic_rails/application_spawner.rb:321:in `start_request_handler'
  passenger (3.0.13) lib/phusion_passenger/classic_rails/application_spawner.rb:275:in `block in handle_spawn_application'
  passenger (3.0.13) lib/phusion_passenger/utils.rb:479:in `safe_fork'
  passenger (3.0.13) lib/phusion_passenger/classic_rails/application_spawner.rb:270:in `handle_spawn_application'
  passenger (3.0.13) lib/phusion_passenger/abstract_server.rb:357:in `server_main_loop'
  passenger (3.0.13) lib/phusion_passenger/abstract_server.rb:206:in `start_synchronously'
  passenger (3.0.13) lib/phusion_passenger/abstract_server.rb:180:in `start'
  passenger (3.0.13) lib/phusion_passenger/classic_rails/application_spawner.rb:149:in `start'
  passenger (3.0.13) lib/phusion_passenger/spawn_manager.rb:219:in `block (2 levels) in spawn_rails_application'
  passenger (3.0.13) lib/phusion_passenger/abstract_server_collection.rb:132:in `lookup_or_add'
  passenger (3.0.13) lib/phusion_passenger/spawn_manager.rb:214:in `block in spawn_rails_application'
  passenger (3.0.13) lib/phusion_passenger/abstract_server_collection.rb:82:in `block in synchronize'
  :10:in `synchronize'
  passenger (3.0.13) lib/phusion_passenger/abstract_server_collection.rb:79:in `synchronize'
  passenger (3.0.13) lib/phusion_passenger/spawn_manager.rb:213:in `spawn_rails_application'
  passenger (3.0.13) lib/phusion_passenger/spawn_manager.rb:132:in `spawn_application'
  passenger (3.0.13) lib/phusion_passenger/spawn_manager.rb:275:in `handle_spawn_application'
  passenger (3.0.13) lib/phusion_passenger/abstract_server.rb:357:in `server_main_loop'
  passenger (3.0.13) lib/phusion_passenger/abstract_server.rb:206:in `start_synchronously'
  passenger (3.0.13) helper-scripts/passenger-spawn-server:99:in `
'
dhoelker commented 12 years ago

mmmh, this helps... https://github.com/zipme/redmine_lightbox/commit/dafcbde15ac967694d3d08458f8c5ee4522bdcc5

dhoelker commented 12 years ago

i downloaded this „older“ version from the mainpage. this version isnt fixed. https://github.com/zipme/redmine_lightbox/zipball/7cd1d66d54f267015dcd0b0d0eadab251918de1d

danmunn commented 12 years ago

Not able to replicate on: CentOS 6.2 Ruby 1.8.7 Passenger (standalone) 3.0.13 Rails 2.3.14 Redmine 1.4.4

mlattke commented 12 years ago

Hello danmunn,

My enviroment where the issue persist

Ubuntu 10.04 TLS Rails 3.2.5 Ruby 1.8.7 Mongrel 1.1.5 Redmine 1.4.3

I will update my Redmine to 1.4.4 and test again.

Regards.,

dhoelker commented 12 years ago

mlattke, try this patch, maybe it works in your case too - my problem is solved with that

https://github.com/zipme/redmine_lightbox/commit/dafcbde15ac967694d3d08458f8c5ee4522bdcc5

mlattke commented 12 years ago

Hello dhoelker,

That works!!....thanks a lot for your help!...