zippy1978 / ghost4j

Java wrapper for Ghostscript C API + PS/PDF document handling API
http://www.ghost4j.org
GNU Lesser General Public License v3.0
64 stars 38 forks source link

Workaround to make ghost4j compatible with JDKs >= 1.8u242 #69

Closed mehrentreich closed 3 years ago

mehrentreich commented 4 years ago

This is only a hacky workaround due to my limited knowledge of the codebase to satisfy the requirements of newer JDKs (see the hint in my commit messages).

I know there is a RemoteInvoke interface which correctly implements the required RMI java.rmi.Remote interface. Unfortunately a call to the PdfConverter.convert() method always picks the regular Invoke interface which then in turn fails with JDKs starting from version 1.8u242 because the RMI spec now requires interfaces which are used for RMI calls to implement java.rmi.Remote.

According to these release notes it seems that it previously worked by accident because this policy wasn't enforced before Java 1.8u242: https://www.oracle.com/technetwork/java/javase/8u241-relnotes-5813177.html

I'd appreciate if any of the project maintainers could come up with a better solution which addresses the root cause of this issue.

4F2E4A2E commented 4 years ago

@zippy1978 looks fine for me. Will you be able and have time to increase the version and to deploy this to maven central?

gargassus commented 4 years ago

Is there any progress here to get this PR merged and deployed?

4F2E4A2E commented 4 years ago

Thx for reminding, I'll take a look into publishing it.

gargassus commented 3 years ago

Hi again, is there any progress with the publishing?

gargassus commented 3 years ago

Is there any hope for this PR to be merged? :)

4F2E4A2E commented 3 years ago

Hey @zippy1978, I will merge this and hope you dont mind.

4F2E4A2E commented 3 years ago

I will try to push on to maven central, I hope to still have the permissions.