search

zipurman / oVIRT_Simple_Backup

A REST API backup using PHP for oVirt 4.2.x
GNU General Public License v3.0
56 stars 32 forks source link

Possible commit this #56

Open ricain59 opened 5 years ago

ricain59 commented 5 years ago

Hello,

I've problem with scheduled backup, because if i've choose dom = 2 and dow = 1 and none on dom, the backup work on dom 2, 3 and 4.

I've changed code on automatedbackup.php, view annex (i've renamed on .txt) automatedbackup.php.txt

I'm not a pro, but works fine.

zipurman commented 5 years ago

The code looks fine but I have no way of testing it as I do not use this anymore. In your comments above, can you clarify the issue? You stated that you chose dom = 2 but also dom = none?

ricain59 commented 5 years ago

Of course i try explain more because my english is poor.

On schedule, if i choose DOW = 2 for exemple and day 2nd (week) and dom = empty, the schedule backup occure on 2nd, 3rd and 4th day (week). Because on this if: "if ( empty( $filedata['numday'] ) || ceil( $dom / 7 ) >= $filedata['numday'] )"

if on 15 july, ceil(15/7) = 3, $filedata['numday'] = 2 (week) , and 3 >= 2 backup started ;) but i want only on 2nd.

I hope you understand my explain.

zipurman commented 5 years ago

I understand now. I will review the code and get that fixed. I can test the logic outside of this project to make sure it works 100%. Thanks for pointing this out!

ricain59 commented 5 years ago

Thank you and thanks for your work, this work fine ;)

zipurman commented 5 years ago

I have pushed out a change that I think will solve this issue. Please test and let me know.

ntox commented 5 years ago

Hello,

I use to be active within the oVirt IRC Channel.

question: How can I remove "simple backup" from the ovirt webUI Panel? I'm no longer using this method.

Thank you for everything zipur!

From: Zip notifications@github.com Sent: Tuesday, July 16, 2019 10:58 AM To: zipurman/oVIRT_Simple_Backup oVIRT_Simple_Backup@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [zipurman/oVIRT_Simple_Backup] Possible commit this (#56)

The code looks fine but I have no way of testing it as I do not use this anymore. In your comments above, can you clarify the issue? You stated that you chose dom = 2 but also dom = none?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/zipurman/oVIRT_Simple_Backup/issues/56?email_source=notifications&email_token=AIQQBATFONDB42TKWEXGSH3P7XOYVA5CNFSM4ID74LSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2BEHWI#issuecomment-511853529, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIQQBAQ7ZKDY4U7BYQ6JJOLP7XOYVANCNFSM4ID74LSA.

ricain59 commented 5 years ago

@ntox : What method use?

zipurman commented 5 years ago

Hey @ntox, Hope all is well with you! I no longer use oVirt as I moved my setup to vmware with a 3rd party provider.

Uninstall steps:

On the Engine command line:

rm /usr/share/ovirt-engine/ui-plugins/simpleBackup* -R service ovirt-engine restart

ntox commented 5 years ago

Hey man! All is well here, hope the same for yourself!

We have ovirt in production 100% with 7-host cluster and networked iSCSI Storage. Using a paid solution for backup (vProtect). It's awesome, and by a great company.

Thank you uninstall command line syntax

Have a great weekend

Best Regards,

​ Anthony Armstrong AJATechnologies www.ajatechnologies.nethttp://www.ajatechnologies.net Tel: 386-202-4880 Cell: 386-334-9547

From: Zip notifications@github.com Sent: Friday, August 30, 2019 12:57 PM To: zipurman/oVIRT_Simple_Backup oVIRT_Simple_Backup@noreply.github.com Cc: Anthony Armstrong anthony@ajatechnologies.net; Mention mention@noreply.github.com Subject: Re: [zipurman/oVIRT_Simple_Backup] Possible commit this (#56)

Hey @ntoxhttps://github.com/ntox, Hope all is well with you! I no longer use oVirt as I moved my setup to vmware with a 3rd party provider.

Uninstall steps:

On the Engine command line:

rm /usr/share/ovirt-engine/ui-plugins/simpleBackup* -R service ovirt-engine restart

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/zipurman/oVIRT_Simple_Backup/issues/56?email_source=notifications&email_token=AIQQBAVQ2LJGPPSHPVN26RLQHFGPLA5CNFSM4ID74LSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5SGRQA#issuecomment-526674112, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIQQBAUX7ZS2XHRXKMQ74R3QHFGPLANCNFSM4ID74LSA.