search

ziqing26 / pe

0 stars 0 forks source link

Add command does not detect case-sensitive duplicates. #7

Open ziqing26 opened 2 years ago

ziqing26 commented 2 years ago

Steps to reproduce:

add c/Bytedance p/software engineer d/2021-12-12 r/resume i/2021-12-18 1030

add c/bytedance p/software engineer d/2021-12-12 r/resume i/2021-12-18 1030

Expected:

Duplicated entry detected as Bytedance and bytedance are the same company.

Actual:

Duplicated entries successfully added without warnings. This is risky because in general they are considered as the same entry.

Screenshot 2021-11-12 at 4.58.38 PM.png

nus-pe-script commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Case sensitive company name

Steps to reproduce:

  1. type command add c/shopee p/software engineer d/2021-12-12 r/resume i/2021-12-20 0830
  2. new entry is added even though the name shop and position are the same as an existing entry

Expected behaviour: name and position should be case insensitive since your UG states that adding an entry with same company name and position is not allowed.

Actual behaviour: new entry is added even though the name shop and position are the same as an existing entry

image.png

[original: nus-cs2103-AY2122S1/pe-interim#5300] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Indeed, we acknowledge that duplicate detection should be incorporated into our design, as the it's very likely that Amazon and amazon refers to the same company. However, this is supposed to be a FeatureFlaw instead of FunctionalityBug, and since this is more related to NFR of the product, it should be of a lower severity level.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason] Severity is Medium as in users' daily typing, it is very likely that they switch between different cases. The inconvenience caused includes duplicated entries and accuracy of finding an application without being noticed. Therefore, I would think this is a medium bug. Attached are the definition of the two severity levels in the textbook here:

severity.Low : A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only.

severity.Medium : A flaw that causes occasional inconvenience to some users but they can continue to use the product.