Validation fails with repeated tags since v4.10.1

zircote / swagger-php

A php swagger annotation and parsing library

http://zircote.github.io/swagger-php/

Apache License 2.0

5.08k stars 933 forks source link

Closed rasmuscnielsen closed 3 months ago

rasmuscnielsen commented 3 months ago

Updating to the latest release, our CI starts failing with "repeated tags".

I'd assume it's related to the introduction of "AugmentTags" processor.

Interestingly, It seems that the examples also have duplicated tags in https://github.com/zircote/swagger-php/pull/1615/files .

Is this a valid approach, or should they be filtered to only have unique tags? Our CI validates swagger files using https://validator.swagger.io/validator/debug which fails

DerManoMann commented 3 months ago

Nah. Reading this I remember thinking about uniqueness, but somehow I lost it.

DerManoMann commented 3 months ago

Deng! Wifi not working at hotel - will have to wait until tomorrow 😕

rasmuscnielsen commented 3 months ago

Thanks a ton @DerManoMann ! It works 🎉