zishan0215 / attendance

Attendance Management System for Computer Departement, JMI
Other
40 stars 131 forks source link

Pull and Push #7

Closed zishan0215 closed 9 years ago

zishan0215 commented 10 years ago

We are having issues related to pull and push requests.. Its better to have this discussion here so that others can see this if they have any problem

wadhwasahil commented 10 years ago

ok

zishan0215 commented 10 years ago

@wadhwasahil you sent me a pull request. however, it contains all the previous files as well

zishan0215 commented 10 years ago

it has 3 commits and the only commit that is of use is the last commit.. other two are repetitions of the code already present ..

wadhwasahil commented 10 years ago

so what to do now?

zishan0215 commented 10 years ago

i cant accept this pull request as this will overwrite the existing code which i have further modified.. send me a pull request of only the changes you made for the teacher view

wadhwasahil commented 10 years ago

but how?

zishan0215 commented 10 years ago

i dont know.. maybe create a branch or something

wadhwasahil commented 10 years ago

i will give you that folder on monday?

zishan0215 commented 10 years ago

copy the files you just created.. then pull the code from my account.. then create a branch for teacher_admin and add those files in the code for that branch.. then send me a request to merge the branch

nickedes commented 10 years ago

i think we all shud make a separate branch of our codes..n den send Pull requests

zishan0215 commented 10 years ago

@nkmittal4994 yes.. you are right

nickedes commented 10 years ago

zishan shud i send u a PR of a dashboard code..or will u add d file..? btw i have to check it..too :P

zishan0215 commented 10 years ago

send me a PR.. if you do it right then leave your steps here for others to see

zishan0215 commented 10 years ago

but send me a PR once youve tested the dashboard

nickedes commented 10 years ago

okie will do :+1:

zishan0215 commented 10 years ago

:-)

nickedes commented 9 years ago

:tada: