Closed otakakot closed 4 months ago
I would like to add a test to check the behavior of the function I am adding, which is the best way to implement it?
I would like to add a test to check the behavior of the function I am adding, which is the best way to implement it?
You could add an integration test that starts the example OP and then initialize the RP with your the new option.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 62.17%. Comparing base (
0992c5f
) to head (9e700d2
). Report is 49 commits behind head on main.:exclamation: Current head 9e700d2 differs from pull request most recent head 0553090. Consider uploading reports for the commit 0553090 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@otakakot I understood you still want to add tests, is that correct? I am waiting with the review until that's done.
@muhlemmer Excuse me, may I have a review at this stage?
The implementation looks good to me :+1:
I would like to add a test to check the behavior of the function I am adding, which is the best way to implement it?
You could add an integration test that starts the example OP and then initialize the RP with your the new option.
https://github.com/zitadel/oidc/pull/579/commits/75723536781fca72bb911366055cd835620f46e1 Tests have been added.
:tada: This PR is included in version 3.22.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Definition of Ready
fixes #574
Fixed
discoveryConfiguration.IDTokenSigningAlgValuesSupported
to be set toWithSupportedSigningAlgorithms()
.I thought about adding and setting
discoveryConfiguration
to therelyingParty
struct field and doingfor _, optFunc := range options{}
after gettingdiscoveryConfiguration
,WithCustomDiscoveryUrl()
had to be processed beforeclient.Discover()
.