zitadel / oidc

Easy to use OpenID Connect client and server library written for Go and certified by the OpenID Foundation
https://zitadel.com
Apache License 2.0
1.38k stars 145 forks source link

fix: Fail safe, if optional endpoints are not given #582

Closed jkroepke closed 6 months ago

jkroepke commented 6 months ago

If discovery document doesn't contains some optional endpoints, calling some endpoints functions may fail hard

Example with end session

Before:

Post "": unsupported protocol scheme ""

After:

end session endpoint not set

Definition of Ready

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 62.03%. Comparing base (0992c5f) to head (1c66947). Report is 40 commits behind head on main.

Files Patch % Lines
pkg/client/client.go 16.66% 9 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #582 +/- ## ========================================== + Coverage 60.06% 62.03% +1.97% ========================================== Files 80 80 Lines 6998 6169 -829 ========================================== - Hits 4203 3827 -376 + Misses 2498 2037 -461 - Partials 297 305 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 3.20.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: