zitadel / oidc

Easy to use OpenID Connect client and server library written for Go and certified by the OpenID Foundation
https://zitadel.com
Apache License 2.0
1.33k stars 138 forks source link

feat: add default signature algorithm #606

Closed nannany closed 3 months ago

nannany commented 4 months ago

Changed the toJoseSignatureAlgorithms function to support not only RS256 but also ES256 and PS256 when an argument of zero length is given. See issue #605 for the reason for selecting ES256 and PS256.

Definition of Ready

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.04%. Comparing base (0992c5f) to head (46ecf9a). Report is 61 commits behind head on main.

:exclamation: Current head 46ecf9a differs from pull request most recent head 911d117

Please upload reports for the commit 911d117 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #606 +/- ## ========================================== + Coverage 60.06% 62.04% +1.98% ========================================== Files 80 81 +1 Lines 6998 6192 -806 ========================================== - Hits 4203 3842 -361 + Misses 2498 2041 -457 - Partials 297 309 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 3.24.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: