feat: add static token option in client

zitadel / zitadel-go

ZITADEL Go - The official client library of ZITADEL for an easy integration into your Go project.

https://zitadel.com

Apache License 2.0

73 stars 29 forks source link

feat: add static token option in client #187

Closed TakumiHaruta closed 6 months ago

TakumiHaruta commented 1 year ago

Description

Close #186

Renamed NewAuthenticator to NewJWTProfileAuthenticator since this function is JWT profile specific.
Added StaticTokenSource type for credentials.PerRPCCredentials interface
Set credentials in NewConnection and switch authentication method by c.staticTokenSource is empty or not

Note

The function NewConnection itself is a bit tightly-coupled to JWT profile method only, so I think the condition to switch auth methods inside NewConnection is not quite clean. Please let me know if you have an idea how to handle this in a better way

livio-a commented 1 year ago

Hey @TakumiHaruta

Just wanted to check the state on this PR. Maybe you missed my review. We would appreciate your contribution 😃

TakumiHaruta commented 1 year ago

@livio-a Hi, sorry for the late reply. Currently I don't have time to spend on contributions... Is it possible for you to fork from my PR and modify it as you want? As long as we can put an access token from Authorization header in go client to use Zitadel API, it's totally fine for us.

livio-a commented 1 year ago

@livio-a Hi, sorry for the late reply. Currently I don't have time to spend on contributions... Is it possible for you to fork from my PR and modify it as you want? As long as we can put an access token from Authorization header in go client to use Zitadel API, it's totally fine for us.

no worries, just wanted to check. i will be on vacation but might check afterwards if i find a solution

hifabienne commented 6 months ago

This PR is more than a year old, and the go lib has been refactored since then. Due to this I will close this PR