zitadel / zitadel-go

ZITADEL Go - The official client library of ZITADEL for an easy integration into your Go project.
https://zitadel.com
Apache License 2.0
73 stars 29 forks source link

feat: release v3 by merging next into main #363

Closed muhlemmer closed 3 months ago

muhlemmer commented 3 months ago

This branch is an intermediate state where next and main are merged together to solve merge conflicts. After the conflicts were resolved the following changes were made:

  1. Regenerate proto stubs to match the latest version from zitadel
  2. Update all go modules, so we make sure no security advisories stay active
  3. Update release info in readme.

BREAKING CHANGES

See past commits from the next branch. This header will trigger v3 release.

Note to merger: This PR must not be squashed in order to keep proper commit history.

Closes https://github.com/zitadel/zitadel-go/issues/348

Definition of Ready

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 4.92147% with 908 lines in your changes missing coverage. Please review.

Project coverage is 0.05%. Comparing base (95f369e) to head (de4f491).

Files Patch % Lines
pkg/authentication/authenticate.go 0.00% 121 Missing :warning:
pkg/client/zitadel/auth/auth_grpc.pb.go 0.00% 106 Missing :warning:
pkg/client/zitadel/instance/instance.pb.go 0.00% 78 Missing :warning:
...client/zitadel/user/v2beta/user_service_grpc.pb.go 0.00% 68 Missing :warning:
pkg/client/client.go 0.00% 67 Missing :warning:
pkg/authentication/oidc/authenticate.go 0.00% 50 Missing :warning:
pkg/client/zitadel/system/system_grpc.pb.go 0.00% 48 Missing :warning:
pkg/client/auth.go 0.00% 40 Missing :warning:
pkg/grpc/middleware/authz.go 0.00% 31 Missing :warning:
pkg/authorization/oauth/context.go 0.00% 29 Missing :warning:
... and 27 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #363 +/- ## ======================================== + Coverage 0.00% 0.05% +0.05% ======================================== Files 76 91 +15 Lines 78068 78928 +860 ======================================== + Hits 0 47 +47 - Misses 78068 78878 +810 - Partials 0 3 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

muhlemmer commented 3 months ago

As next dropped support for go <1.21 we need to disable the test requirement for v1.20

muhlemmer commented 3 months ago

@adlerhurst

not sure if the code for the NewClient functions would get more readable if we would use a helper function instead of copy pasting the code.

Instead of the protoc stuff in the build/zitadel folder would it make builds easier if we switch to buf?

I agree. But such a change should be formalized in a user-story and planned. The scope of this PR is merging the current state of next into main, which was neglected for quite some months now.

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 2.3.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: