zitmen / thunderstorm

ThunderSTORM: a comprehensive ImageJ plugin for SMLM data analysis and super-resolution imaging
http://zitmen.github.io/thunderstorm/
GNU General Public License v3.0
93 stars 42 forks source link

Post-processing steps in the exported protocol persist after reset #11

Closed zitmen closed 9 years ago

zitmen commented 9 years ago
What steps will reproduce the problem?
1. Open any dataset and perform a simple filtering step (any: filter, merging, etc...)
2. Export the list of the molecules and the protocol.
3. Go back to the table, click reset and perform another or different filtering steps.
4. Export once again the list of the molecules and the protocol.
5. At the bottom of the second exported protocol file, the post-processing field displays
an odd scrambled version of the latest filtering step and the previously cancelled
ones.
6. And so on for any subsequent filtering steps (see ex attached).

What is the expected output? What do you see instead?
The protocol file exported at the same time as the molecule list should only contain
the filtering steps used to create this list, not all the cancelled filters into a
merged filtering string that keeps expanding. But, it seems that the filtering is actually
doing its job well on the data: only the history within the protocol file seems affected.

What version of the product are you using? On what operating system?
ThunderSTORM dev-2014-04-28 still has the issue, exist in stable v1.2, ImageJ (within
Fiji or not) 1.48v, Java 1.60_065, Mac OSX 10.9 or Windows 7.

Congrats on the paper!
Alex

Original issue reported on code.google.com by alex.f.carisey on 2014-04-29 09:53:10


zitmen commented 9 years ago
(No text was entered with this change)

Original issue reported on code.google.com by zitmen on 2014-05-05 17:42:24

zitmen commented 9 years ago
Thanks for reporting. This one was pretty sneaky :)
Fixed in commit 22e74f7. New daily build will be available soon.

Original issue reported on code.google.com by zitmen on 2014-05-06 17:18:39

zitmen commented 9 years ago
(No text was entered with this change)

Original issue reported on code.google.com by zitmen on 2014-05-12 19:07:13

zitmen commented 9 years ago
(No text was entered with this change)

Original issue reported on code.google.com by zitmen on 2014-05-12 19:08:29