zitmen / thunderstorm

ThunderSTORM: a comprehensive ImageJ plugin for SMLM data analysis and super-resolution imaging
http://zitmen.github.io/thunderstorm/
GNU General Public License v3.0
95 stars 42 forks source link

Suggestion for improvement: allow non-integer pixel coordinates for the Visualization ROI #12

Closed zitmen closed 9 years ago

zitmen commented 9 years ago
What steps will reproduce the problem?
1. Import a localizations file
2. Launch the Visualization
3. Input non integer pixel coordinates in the "ROI" dialog (see attached
image) 

What is the expected output? What do you see instead?
As the reconstruction image has an arbitrary size, it could be possible to specify
any ROI coordinates in the Visualization dialog, not just integers corresponding to
actual pixels on the camera sensor. But using non-integer coordinates generates a java.lang.NumberFormatException
error, so only integer ROI coordinates are possible.

Why using non-integer would be useful: I'm using 2D, lower resolution reconstructions
(40x40 nm) where I draw small ROIs that are reconstructed from the localization file,
in 3D at a much higher resolution (4x4x4 nm). Reconstructing the whole image at this
scale would be impossible given the necessary memory. However, the 3D high-resolution
reconstructions are not exactly at the same place than the ROIs on the 2D low-resolution
image, because it is not possible to use non-integer ROI coordinates in the Visualization
process: the rounding to the nearest camera pixel (160 nm in my case) generates a significant
shift.

What version of the product are you using? On what operating system?

Please provide any additional information below.
Thanks for your help and reactivity!

Original issue reported on code.google.com by lechristophe on 2014-05-12 09:08:11


zitmen commented 9 years ago
Another good suggestion. Thanks.

Resolved in commit b8d28934e7a6. Now available in via the built-in updater (dev-2014-05-12-b1).

Original issue reported on code.google.com by zitmen on 2014-05-12 19:03:45

zitmen commented 9 years ago
(No text was entered with this change)

Original issue reported on code.google.com by zitmen on 2014-05-12 19:08:13

zitmen commented 9 years ago
Hi,

Thanks for the change. I am able to input sub-pixel ROI coordinates in the Visualization
dialog. However, it does not seem to work when calling the Visualization from a macro:
I get the java.lang.NumberFormatException error. Could you look into it? Thanks a lot.

Original issue reported on code.google.com by lechristophe on 2014-05-15 09:26:05

zitmen commented 9 years ago
I am sorry about that. Hopefully, it is fixed now.

Fixed in commit 9f10a1f77098. New daily build (dev-2014-05-15-b1) is available.

Original issue reported on code.google.com by zitmen on 2014-05-15 17:04:43